SiyaoIsHiding commented on PR #1916: URL: https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2030578292
Questions: 1. I tried hard, but I could not find an example of how to use MicroProfile with our driver, especially how to instantiate a MicroProfile registry. May I confirm, is it the user's responsibility to implement and pass in a MicroProfile `MetricRegistry`? In this case, is it the user's responsibility to ensure there is no memory leak? 2. Do we only clear the metrics when a session is closed? Or do we also clear the node metrics when a node goes down? Progress: 1. Dropwizard is not leaking memory in the way that Micrometer does. 2. I refactored `clearMetrics()` and put it into DefaultSession's `closeAsync` and `forceCloseAsync`. Micrometer does not leak memory now. It is now pending for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
