adutra commented on PR #1916: URL: https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2045772779
@absurdfarce it looks like we reverted not only the commit that made the suppliers members of the corresponding updaters; but also the commit that made the gauges contain weak references in the first place. So the current state of this PR looks consistent to me: the identified resource leak is fixed, and no metric risks being prematurely GC'ed by accident. We may, however, wish to keep the idea of weak gauge references, as a precautionary measure. In this case we need to either bring back the reverted changes, or introduce them in a follow-up PR. I'm fine with either approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
