absurdfarce commented on PR #1916: URL: https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2045980061
Ah, excellent point @adutra ... you're absolutely right. I forgot that we also made that change to specifically enable weak references but yeah, without that change there is no danger. I agree the PR is in a consistent state without it. @SiyaoIsHiding it looks like you reverted the reverts that removed those changes... but I don't think we want to do that. Moving to weak references and making the Suppliers into member values is a more intrusive change and I guess I'd prefer to just fix it by more vigorous cleanup of metrics on session close... which is what this PR accomplishes. So I guess I'm arguing to revert the reverts of the reverts. @adutra do you have any major objection to that? What do you think @SiyaoIsHiding ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
