[ 
https://issues.apache.org/jira/browse/CASSANDRA-19697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855967#comment-17855967
 ] 

Brandon Williams commented on CASSANDRA-19697:
----------------------------------------------

bq. there is a huge problem in virtually all existing Cassandra clusters: 
timeouts on node bounces

I don't understand why they would be timeouts if we are forcibly closing the 
connections.  Indeed, this test is expecting a NoHostAvailable exception after 
injecting the failure.

bq.  If we do not wait for dispatcher threads, I recommend we use disablebinary 
-f for those tests

[~adelapena] will this test still be valid if reworked without injecting the 
byteman failure?

bq. But in general, I think we should wait for the accepted client tasks to 
complete.

I don't disagree, it seems like the correct thing to do, but there is no need 
to wait longer than the native transport timeout, so maybe we should avoid 
hanging with something like 
[this|https://github.com/driftx/cassandra/commit/3c37f69e88b5d220f5f37b693bfc9e8ef27d9678].
  That is still too long for this test to pass as it is, though.

Also, I assume we don't wait in 4.1 so that no behavior was changed?

> Test failure: 
> materialized_views_test.py::TestMaterializedViews::test_rename_column_atomicity
> ---------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-19697
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19697
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Feature/Materialized Views
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Normal
>             Fix For: 5.0-rc, 5.x
>
>         Attachments: shutdown_stuck.txt
>
>
> Breaking this out from CASSANDRA-19683.  The byteman script fails to execute 
> in 5.0/trunk after CASSANDRA-19534.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to