[ 
https://issues.apache.org/jira/browse/CASSANDRA-19651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874532#comment-17874532
 ] 

Dmitry Konstantinov commented on CASSANDRA-19651:
-------------------------------------------------

trunk - 3 test failures, all of them looks like not related to the current 
changes
 * distributed.test.IPMembershipTest#startupNewIP-_jdk11, flaky, local re-run 
is ok
{code:java}
% ant test-jvm-dtest-some 
-Dtest.name=org.apache.cassandra.distributed.test.IPMembershipTest 
-Dtest.methods=startupNewIP
...
BUILD SUCCESSFUL
Total time: 1 minute 53 seconds
{code}

 * 
distributed.test.NativeTransportEncryptionOptionsTest#testOptionalMtlsModeDoNotAllowNonSSLConnections-cassandra.testtag_IS_UNDEFINED
 - known flaky CASSANDRA-19281, local re-run is ok
{code:java}
% ant test-jvm-dtest-some 
-Dtest.name=org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
 -Dtest.methods=testOptionalMtlsModeDoNotAllowNonSSLConnections
...
BUILD SUCCESSFUL
Total time: 37 seconds
{code}

 * 
bootstrap_test.TestBootstrap#test_consistent_range_movement_false_with_rf1_should_succeed
 - flaky, local re-run is ok
{code:java}
 % pytest --cassandra-dir=/Users/dmitry/IdeaProjects/cassandra-trunk 
bootstrap_test.py::TestBootstrap::test_consistent_range_movement_false_with_rf1_should_succeed
...
test_consistent_range_movement_false_with_rf1_should_succeed passed 1 out of 
the required 1 times. Success!

===End Flaky Test Report===
============================================================= 1 passed, 197 
warnings in 161.10s (0:02:41) 
=============================================================
{code}

> idealCLWriteLatency metric reports the worst response time instead of the 
> time when ideal CL is satisfied
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-19651
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19651
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Observability
>            Reporter: Dmitry Konstantinov
>            Assignee: Dmitry Konstantinov
>            Priority: Normal
>             Fix For: 4.1.x, 5.0.x, 5.x
>
>         Attachments: 
> ci_summary-cassandra-4.0-a75f6c3e81f677e50c0a0d467dd5dad672f923e3.html, 
> ci_summary-cassandra-4.1-1ed312f881c0c170c8833ff9fbf397ab8fc625cc.html, 
> ci_summary-cassandra-5.0-009f2982ac88d9c9bc0a7a7d29220f055aa7f11e.html, 
> ci_summary-trunk-da68729322515b4a7a698b73a0154ecdeb3abf39.html, 
> result_details-cassandra-4.0-a75f6c3e81f677e50c0a0d467dd5dad672f923e3.tar.gz, 
> result_details-cassandra-5.0-009f2982ac88d9c9bc0a7a7d29220f055aa7f11e.tar.gz, 
> result_details-trunk-da68729322515b4a7a698b73a0154ecdeb3abf39.tar.gz, 
> select-junit-tests-rerun-4.1.zip
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> org.apache.cassandra.service.AbstractWriteResponseHandler:
> {code:java}
> private final void decrementResponseOrExpired()
> {
>     int decrementedValue = responsesAndExpirations.decrementAndGet();
>     if (decrementedValue == 0)
>     {
>         // The condition being signaled is a valid proxy for the CL being 
> achieved
>         // Only mark it as failed if the requested CL was achieved.
>         if (!condition.isSignalled() && requestedCLAchieved)
>         {
>             replicaPlan.keyspace().metric.writeFailedIdealCL.inc();
>         }
>         else
>         {
>             
> replicaPlan.keyspace().metric.idealCLWriteLatency.addNano(nanoTime() - 
> queryStartNanoTime);
>         }
>     }
> } {code}
> Actual result: responsesAndExpirations is a total number of replicas across 
> all DCs which does not depend on the ideal CL, so the metric value for 
> replicaPlan.keyspace().metric.idealCLWriteLatency is updated when we get the 
> latest response/timeout for all replicas.
> Expected result: replicaPlan.keyspace().metric.idealCLWriteLatency is updated 
> when we get enough responses from replicas according to the ideal CL.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to