[ https://issues.apache.org/jira/browse/CASSANDRA-19651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17875547#comment-17875547 ]
Ariel Weisberg commented on CASSANDRA-19651: -------------------------------------------- Thanks, I've also been triaging them, I don't think they are related to your patch it's our CI environment, but when I did a baseline run of trunk there were some that didn't seem to fail, but also a lot of noise. I am going to try it on ASF CI for 5.0/5.1 and if that looks good I'll go ahead and merge. These don't appear yet since they are queued and haven't started https://ci-cassandra.apache.org/job/Cassandra-devbranch-5/54/ https://ci-cassandra.apache.org/job/Cassandra-devbranch-5/55/ > idealCLWriteLatency metric reports the worst response time instead of the > time when ideal CL is satisfied > --------------------------------------------------------------------------------------------------------- > > Key: CASSANDRA-19651 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19651 > Project: Cassandra > Issue Type: Bug > Components: Legacy/Observability > Reporter: Dmitry Konstantinov > Assignee: Dmitry Konstantinov > Priority: Normal > Fix For: 4.1.x, 5.0.x, 5.x > > Attachments: > ci_summary-cassandra-4.0-a75f6c3e81f677e50c0a0d467dd5dad672f923e3.html, > ci_summary-cassandra-4.1-1ed312f881c0c170c8833ff9fbf397ab8fc625cc.html, > ci_summary-cassandra-5.0-009f2982ac88d9c9bc0a7a7d29220f055aa7f11e.html, > ci_summary-trunk-da68729322515b4a7a698b73a0154ecdeb3abf39.html, > result_details-cassandra-4.0-a75f6c3e81f677e50c0a0d467dd5dad672f923e3.tar.gz, > result_details-cassandra-5.0-009f2982ac88d9c9bc0a7a7d29220f055aa7f11e.tar.gz, > result_details-trunk-da68729322515b4a7a698b73a0154ecdeb3abf39.tar.gz, > select-junit-tests-rerun-4.1.zip > > Time Spent: 20m > Remaining Estimate: 0h > > org.apache.cassandra.service.AbstractWriteResponseHandler: > {code:java} > private final void decrementResponseOrExpired() > { > int decrementedValue = responsesAndExpirations.decrementAndGet(); > if (decrementedValue == 0) > { > // The condition being signaled is a valid proxy for the CL being > achieved > // Only mark it as failed if the requested CL was achieved. > if (!condition.isSignalled() && requestedCLAchieved) > { > replicaPlan.keyspace().metric.writeFailedIdealCL.inc(); > } > else > { > > replicaPlan.keyspace().metric.idealCLWriteLatency.addNano(nanoTime() - > queryStartNanoTime); > } > } > } {code} > Actual result: responsesAndExpirations is a total number of replicas across > all DCs which does not depend on the ideal CL, so the metric value for > replicaPlan.keyspace().metric.idealCLWriteLatency is updated when we get the > latest response/timeout for all replicas. > Expected result: replicaPlan.keyspace().metric.idealCLWriteLatency is updated > when we get enough responses from replicas according to the ideal CL. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org