GutoVeronezi commented on PR #8547: URL: https://github.com/apache/cloudstack/pull/8547#issuecomment-1910393568
> @GutoVeronezi would it make sense to keep the issue open for further work... Sure do, because the issue is not being fixed by this PR. > ... are you -1 on the PR changes as well? No. Indeed, I proposed the externalization of the timeout settings, vide https://github.com/apache/cloudstack/pull/8502#discussion_r1450410628 (and the author of the PR was against it at first: https://github.com/apache/cloudstack/pull/8502#discussion_r1452036208). My point is that this PR does not even touch the essence of the issue; therefore, saying it solves the issue does not make sense. > binding does not apply to PRs. Thanks, @DaanHoogland. I think I missed this detail from the docs. > @GutoVeronezi , I suppose you are referring to the solution mentioned in this comment: [#8502 (comment)](https://github.com/apache/cloudstack/pull/8502#discussion_r1450506118) ? > > If so, this is a good idea and would obsolete this PR, but not without implementation. Do you have code ready to replace the code here? No, there is no code ready yet; before implementing something every each way, we should discuss the pros and cons. That is the purpose of the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
