vishesh92 commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1466578342
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##########
@@ -121,7 +122,9 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO
networkVO, NetworkOffe
public boolean hostConnect(long hostId, long poolId) throws
StorageConflictException {
StoragePool pool = (StoragePool)
this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true,
pool);
- cmd.setWait(60);
+ cmd.setWait(Wait.value() / 5);
Review Comment:
For ModifyStoragePoolCommand, we don't externalize the timeout to avoid
confusion for the user. Since, the required timeout can vary depending on the
provider in use and we are only setting the wait for default host listener for
now. Instead, we reuse the global wait setting by dividing it by 5 making the
default value of 6 minutes (1800/5 = 360s) for ModifyStoragePoolCommand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
