GutoVeronezi commented on code in PR #8547:
URL: https://github.com/apache/cloudstack/pull/8547#discussion_r1466636892
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/datastore/provider/DefaultHostListener.java:
##########
@@ -121,7 +122,9 @@ private NicTO createNicTOFromNetworkAndOffering(NetworkVO
networkVO, NetworkOffe
public boolean hostConnect(long hostId, long poolId) throws
StorageConflictException {
StoragePool pool = (StoragePool)
this.dataStoreMgr.getDataStore(poolId, DataStoreRole.Primary);
ModifyStoragePoolCommand cmd = new ModifyStoragePoolCommand(true,
pool);
- cmd.setWait(60);
+ cmd.setWait(Wait.value() / 5);
Review Comment:
User also might increase `wait` to 18000 and we would have 1 hour here. It
does not make sense to use an unfounded math function to derive a value;
please, either use the same configuration or externalize a new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
