DaanHoogland commented on code in PR #8230:
URL: https://github.com/apache/cloudstack/pull/8230#discussion_r1474332923
##########
usage/src/main/java/com/cloud/usage/parser/IPAddressUsageParser.java:
##########
@@ -148,10 +150,9 @@ private static void createUsageRecord(long zoneId, long
runningTime, Date startD
DecimalFormat dFormat = new DecimalFormat("#.######");
String usageDisplay = dFormat.format(usage);
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Creating IP usage record with id: " + ipId + ",
usage: " + usageDisplay + ", startDate: " + startDate + ", endDate: " + endDate
+
- ", for account: " + account.getId());
- }
+ s_logger.debug(String.format("Creating IP usage record with id [%s],
usage [%s], startDate [%s], and endDate [%s], for account [%s].",
Review Comment:
guard remmoved while parameters are still evaluated
##########
usage/src/main/java/com/cloud/usage/parser/LoadBalancerUsageParser.java:
##########
@@ -145,10 +147,9 @@ private static void createUsageRecord(int type, long
runningTime, Date startDate
DecimalFormat dFormat = new DecimalFormat("#.######");
String usageDisplay = dFormat.format(usage);
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Creating Volume usage record for load balancer: "
+ lbId + ", usage: " + usageDisplay + ", startDate: " + startDate + ", endDate:
" +
- endDate + ", for account: " + account.getId());
- }
+ s_logger.debug(String.format("Creating usage record for load balancer
with id [%s], usage [%s], startDate [%s], and endDate [%s], for account [%s].",
Review Comment:
guard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
