DaanHoogland commented on code in PR #8230:
URL: https://github.com/apache/cloudstack/pull/8230#discussion_r1474335858
##########
usage/src/main/java/com/cloud/usage/parser/VMSnapshotUsageParser.java:
##########
@@ -133,10 +135,9 @@ private static void createUsageRecord(int type, long
runningTime, Date startDate
DecimalFormat dFormat = new DecimalFormat("#.######");
String usageDisplay = dFormat.format(usage);
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Creating VMSnapshot Id:" + vmSnapshotId + " Volume
usage record for vol: " + volId + ", usage: " + usageDisplay + ", startDate: "
+ startDate + ", endDate: " +
- endDate + ", for account: " + account.getId());
- }
+ s_logger.debug(String.format("Creating usage record for VMSnapshot
with id [%s], vol [%s], usage [%s], startDate [%s], and endDate [%s], for
account [%s].",
Review Comment:
guard
##########
usage/src/main/java/com/cloud/usage/parser/VPNUserUsageParser.java:
##########
@@ -141,10 +143,9 @@ private static void createUsageRecord(int type, long
runningTime, Date startDate
DecimalFormat dFormat = new DecimalFormat("#.######");
String usageDisplay = dFormat.format(usage);
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Creating VPN user:" + userId + " usage record,
usage: " + usageDisplay + ", startDate: " + startDate + ", endDate: " + endDate
+
- ", for account: " + account.getId());
- }
+ s_logger.debug(String.format("Creating usage record for VPN user [%s],
usage [%s], startDate [%s], and endDate [%s], for account [%s].",
Review Comment:
guard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
