DaanHoogland commented on code in PR #8230:
URL: https://github.com/apache/cloudstack/pull/8230#discussion_r1474333619
##########
usage/src/main/java/com/cloud/usage/parser/NetworkUsageParser.java:
##########
@@ -102,10 +104,10 @@ public static boolean parse(AccountVO account, Date
startDate, Date endDate) {
long totalBytesReceived = networkInfo.getBytesRcvd();
if ((totalBytesSent > 0L) || (totalBytesReceived > 0L)) {
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Creating usage record, total bytes sent: "
+ toHumanReadableSize(totalBytesSent) + ", total bytes received: " +
toHumanReadableSize(totalBytesReceived) + " for account: " +
- account.getId() + " in availability zone " +
networkInfo.getZoneId() + ", start: " + startDate + ", end: " + endDate);
- }
+ s_logger.debug(String.format("Creating usage record, total
bytes sent [%s], total bytes received [%s], startDate [%s], and endDate [%s],
for account [%s] in " +
Review Comment:
guard
##########
usage/src/main/java/com/cloud/usage/parser/PortForwardingUsageParser.java:
##########
@@ -145,10 +147,9 @@ private static void createUsageRecord(int type, long
runningTime, Date startDate
DecimalFormat dFormat = new DecimalFormat("#.######");
String usageDisplay = dFormat.format(usage);
- if (s_logger.isDebugEnabled()) {
- s_logger.debug("Creating usage record for port forwarding rule: "
+ pfId + ", usage: " + usageDisplay + ", startDate: " + startDate + ", endDate:
" +
- endDate + ", for account: " + account.getId());
- }
+ s_logger.debug(String.format("Creating usage record for port
forwarding rule [%s], usage [%s], startDate [%s], and endDate [%s], for account
[%s].",
Review Comment:
guard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
