piyush5netapp commented on code in PR #13053:
URL: https://github.com/apache/cloudstack/pull/13053#discussion_r3208797114


##########
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/KvmFileBasedStorageVmSnapshotStrategy.java:
##########
@@ -77,6 +77,8 @@ public class KvmFileBasedStorageVmSnapshotStrategy extends 
StorageVMSnapshotStra
 
     private static final List<Storage.StoragePoolType> 
supportedStoragePoolTypes = List.of(Storage.StoragePoolType.Filesystem, 
Storage.StoragePoolType.NetworkFilesystem, 
Storage.StoragePoolType.SharedMountPoint);
 
+    private static final String ONTAP_PROVIDER_NAME = "NetApp ONTAP";

Review Comment:
   @winterhazel I did not find any suitable place in cloud-api for keeping this 
constant, It would be helpful if you could point out some place to keep this 
constant. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to