piyush5netapp commented on code in PR #13053:
URL: https://github.com/apache/cloudstack/pull/13053#discussion_r3208809109
##########
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java:
##########
@@ -1340,6 +1340,15 @@ private void
createManagedVolumeCopyTemplateAsync(VolumeInfo volumeInfo, Primary
primaryDataStore.setDetails(details);
grantAccess(volumeInfo, destHost, primaryDataStore);
+ volumeInfo = volFactory.getVolume(volumeInfo.getId(),
primaryDataStore);
+ // For Netapp ONTAP iscsiName or Lun path is available only after
grantAccess
+ String managedStoreTarget = volumeInfo.get_iScsiName() != null ?
volumeInfo.get_iScsiName() : volumeInfo.getUuid();
+ details.put(PrimaryDataStore.MANAGED_STORE_TARGET,
managedStoreTarget);
+ primaryDataStore.setDetails(details);
Review Comment:
No — these are different details. The map here is the in-memory transport
details on PrimaryDataStoreImpl (serialized into PrimaryDataStoreTO for the
agent's CopyCommand), not the DB-persisted storage pool details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
