rhtyd commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding
Support for NoVNC Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r135541551
##########
File path: server/src/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -414,7 +423,7 @@ private String composeThumbnailUrl(String rootUrl,
VirtualMachine vm, HostVO hos
return sb.toString();
}
- private String composeConsoleAccessUrl(String rootUrl, VirtualMachine vm,
HostVO hostVo) {
+ private String composeConsoleAccessUrl(String rootUrl, VirtualMachine vm,
HostVO hostVo, Boolean webSocketRequest) {
Review comment:
Same comment as above, the `Boolean` can be refactored into a native
`boolean` and avoid unboxing and NPEs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
