rhtyd commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding
Support for NoVNC Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r135542513
##########
File path:
services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxySecureServerFactoryImpl.java
##########
@@ -112,8 +117,7 @@ public SSLServerSocket createSSLServerSocket(int port)
throws IOException {
SSLServerSocket srvSock = null;
SSLServerSocketFactory ssf = sslContext.getServerSocketFactory();
srvSock = (SSLServerSocket)ssf.createServerSocket(port);
- srvSock.setEnabledProtocols(SSLUtils.getRecommendedProtocols());
- srvSock.setEnabledCipherSuites(SSLUtils.getRecommendedCiphers());
Review comment:
Let's keep the configured list of cipher suites. Check and fix this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
