rhtyd commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding
Support for NoVNC Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r135541334
##########
File path: server/src/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -245,8 +247,15 @@ private void handleThumbnailRequest(HttpServletRequest
req, HttpServletResponse
}
}
- private void handleAccessRequest(HttpServletRequest req,
HttpServletResponse resp, long vmId) {
+ private void handleAccessRequest(HttpServletRequest req,
HttpServletResponse resp, long vmId,Boolean webSocketRequest) {
Review comment:
Add a space before `Boolean`, you may use `boolean` to avoid doing `null `
checks everywhere
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
