rhtyd commented on a change in pull request #2204: [CLOUDSTACK-10025] Adding
Support for NoVNC Console for KVM and XENSERVER
URL: https://github.com/apache/cloudstack/pull/2204#discussion_r135541151
##########
File path: server/src/com/cloud/servlet/ConsoleProxyServlet.java
##########
@@ -181,10 +181,12 @@ protected void doGet(HttpServletRequest req,
HttpServletResponse resp) {
return;
}
+ String websocketConsole = req.getParameter("websocketconsole");
Review comment:
Why not make this boolean in the first place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
