onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519870665 There are other sources for exceptions, not just the part that did `return null`, so I would assume that there is already some sort of error handling and setting error state in place. Is this not the case? I want to avoid duplicating something that's already done... The NPE was not handled properly anywhere AFAIK, so nothing would properly set an error state.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
