onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-520857458 So, after some more digging, I came to the conclusion that there are two major code paths how the snapshot creation can be reached: - via `org.apache.cloudstack.storage.vmsnapshot.DefaultVMSnapshotStrategy#takeVMSnapshot`: In this case, there is already a finally clause that ensures the snapshot transitions to Error state - via `com.cloud.vm.snapshot.VMSnapshotManagerImpl#orchestrateCreateVMSnapshot(com.cloud.vm.snapshot.VmWorkCreateVMSnapshot)`: This is where the NPE happens, and I have absolutely no idea how this method is called. There are no direct references to it, and the `@ReflectionUse` annotation indicates that something generates dynamic calls to it. @rhtyd Do you have any idea where this routine is called and how errors are handled?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
