(commons-pool) branch POOL_2_X updated: Add missing assertions

[ggregory]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch POOL_2_X
in repository https://gitbox.apache.org/repos/asf/commons-pool.git


The following commit(s) were added to refs/heads/POOL_2_X by this push:
     new 1ccc0081 Add missing assertions
1ccc0081 is described below

commit 1ccc0081427e528073aae152ba08c18c2d777090
Author: Gary Gregory <garydgreg...@gmail.com>
AuthorDate: Sun Nov 24 16:11:40 2024 -0500

    Add missing assertions
---
 .../java/org/apache/commons/pool2/impl/TestEvictionConfig.java | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java 
b/src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java
index 95db65b9..4f25a29c 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestEvictionConfig.java
@@ -17,6 +17,7 @@
 package org.apache.commons.pool2.impl;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 
 import java.time.Duration;
 
@@ -30,7 +31,6 @@ public class TestEvictionConfig {
     @Test
     public void testConstructor1s() {
         final EvictionConfig config = new EvictionConfig(Duration.ofMillis(1), 
Duration.ofMillis(1), 1);
-
         assertEquals(1, config.getIdleEvictDuration().toMillis());
         assertEquals(1, config.getIdleEvictTime());
         assertEquals(1, config.getIdleEvictTimeDuration().toMillis());
@@ -38,12 +38,13 @@ public class TestEvictionConfig {
         assertEquals(1, config.getIdleSoftEvictTime());
         assertEquals(1, config.getIdleSoftEvictTimeDuration().toMillis());
         assertEquals(1, config.getMinIdle());
+        // toString() should never throw
+        assertFalse(config.toString().isEmpty());
     }
 
     @Test
     public void testConstructorZerosDurations() {
         final EvictionConfig config = new EvictionConfig(Duration.ZERO, 
Duration.ZERO, 0);
-
         assertEquals(Long.MAX_VALUE, config.getIdleEvictDuration().toMillis());
         assertEquals(Long.MAX_VALUE, config.getIdleEvictTime());
         assertEquals(Long.MAX_VALUE, 
config.getIdleEvictTimeDuration().toMillis());
@@ -51,13 +52,14 @@ public class TestEvictionConfig {
         assertEquals(Long.MAX_VALUE, config.getIdleSoftEvictTime());
         assertEquals(Long.MAX_VALUE, 
config.getIdleSoftEvictTimeDuration().toMillis());
         assertEquals(0, config.getMinIdle());
+        // toString() should never throw
+        assertFalse(config.toString().isEmpty());
     }
 
     @Test
     public void testConstructorZerosMillis() {
         @SuppressWarnings("deprecation")
         final EvictionConfig config = new EvictionConfig(0, 0, 0);
-
         assertEquals(Long.MAX_VALUE, config.getIdleEvictDuration().toMillis());
         assertEquals(Long.MAX_VALUE, config.getIdleEvictTime());
         assertEquals(Long.MAX_VALUE, 
config.getIdleEvictTimeDuration().toMillis());
@@ -65,6 +67,8 @@ public class TestEvictionConfig {
         assertEquals(Long.MAX_VALUE, config.getIdleSoftEvictTime());
         assertEquals(Long.MAX_VALUE, 
config.getIdleSoftEvictTimeDuration().toMillis());
         assertEquals(0, config.getMinIdle());
+        // toString() should never throw
+        assertFalse(config.toString().isEmpty());
     }
 
 }