This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git


The following commit(s) were added to refs/heads/master by this push:
     new 555182d1 Add missing assertions
555182d1 is described below

commit 555182d112aceb02702208959bbb23120e0dac5f
Author: Gary Gregory <[email protected]>
AuthorDate: Sun Nov 24 16:12:28 2024 -0500

    Add missing assertions
---
 .../java/org/apache/commons/pool3/impl/TestEvictionConfig.java     | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git 
a/src/test/java/org/apache/commons/pool3/impl/TestEvictionConfig.java 
b/src/test/java/org/apache/commons/pool3/impl/TestEvictionConfig.java
index d3719252..9a7a825b 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestEvictionConfig.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestEvictionConfig.java
@@ -17,6 +17,7 @@
 package org.apache.commons.pool3.impl;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
 
 import java.time.Duration;
 
@@ -30,19 +31,21 @@ public class TestEvictionConfig {
     @Test
     public void testConstructor1s() {
         final EvictionConfig config = new EvictionConfig(Duration.ofMillis(1), 
Duration.ofMillis(1), 1);
-
         assertEquals(1, config.getIdleEvictDuration().toMillis());
         assertEquals(1, config.getIdleSoftEvictDuration().toMillis());
         assertEquals(1, config.getMinIdle());
+        // toString() should never throw
+        assertFalse(config.toString().isEmpty());
     }
 
     @Test
     public void testConstructorZerosDurations() {
         final EvictionConfig config = new EvictionConfig(Duration.ZERO, 
Duration.ZERO, 0);
-
         assertEquals(Long.MAX_VALUE, config.getIdleEvictDuration().toMillis());
         assertEquals(Long.MAX_VALUE, 
config.getIdleSoftEvictDuration().toMillis());
         assertEquals(0, config.getMinIdle());
+        // toString() should never throw
+        assertFalse(config.toString().isEmpty());
     }
 
 }

Reply via email to