olabusayoT commented on code in PR #1420:
URL: https://github.com/apache/daffodil/pull/1420#discussion_r1943596961
##########
daffodil-cli/src/main/scala/org/apache/daffodil/cli/InfosetTypes.scala:
##########
@@ -71,15 +71,15 @@ import org.xml.sax.helpers.DefaultHandler
object InfosetType extends Enumeration {
type Type = Value
- val EXI = Value("exi")
Review Comment:
So it looks like it's recommended but not strictly enforced from
https://docs.scala-lang.org/scala3/guides/migration/incompatibility-table.html#type-inference
`It is always good practice to write the result types of all public values
and methods explicitly. It prevents the public API of your library from
changing with the Scala version, because of different inferred types. This can
be done prior to the Scala 3 migration by using the
[ExplicitResultTypes](https://scalacenter.github.io/scalafix/docs/rules/ExplicitResultTypes.html)
rule in Scalafix.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
