stevedlawrence commented on code in PR #1420:
URL: https://github.com/apache/daffodil/pull/1420#discussion_r1943597604
##########
daffodil-cli/src/main/scala/org/apache/daffodil/cli/InfosetTypes.scala:
##########
@@ -71,15 +71,15 @@ import org.xml.sax.helpers.DefaultHandler
object InfosetType extends Enumeration {
type Type = Value
- val EXI = Value("exi")
Review Comment:
According to the Scala 3 book:
https://docs.scala-lang.org/scala3/book/methods-most.html
It says
> Declaring the method return type is optional
and
> It is recommended to annotate publicly visible methods with their return
type. Declaring the return type can make it easier to understand it when you
look at it months or years later, or when you look at another person’s code.
So I don't think it's required, but is just good practice. But we have so
many public members that I think it would make things too verbose. We may
should be better about marking things as private, but that's a whole other
effort, and it's probably not worth it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
