stevedlawrence commented on code in PR #1420:
URL: https://github.com/apache/daffodil/pull/1420#discussion_r1943587635
##########
daffodil-cli/src/main/scala/org/apache/daffodil/cli/InfosetTypes.scala:
##########
@@ -71,15 +71,15 @@ import org.xml.sax.helpers.DefaultHandler
object InfosetType extends Enumeration {
type Type = Value
- val EXI = Value("exi")
Review Comment:
The `SpecifyReturnType` fix seems to add a lot of extra verbosity. I assume
this is just a style change and not something deprecated by scala 2.13 or 3.x?
There may be some places where having an explicit return type might be useful,
but I'm not sure we should require it everywhere if future scala versions don't
require it.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
