stevedlawrence commented on code in PR #1434:
URL: https://github.com/apache/daffodil/pull/1434#discussion_r1956194088
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/PrimitivesTextNumber.scala:
##########
@@ -464,6 +464,7 @@ case class ConvertTextStandardNumberPrim(e: ElementBase)
),
pattern
)
+ case _ => Assert.impossibleCase("default case should not be reached")
Review Comment:
This kinds of `case _ => Assert.impossible` always concern me a little bit
when its not clear what's impossible about it. Is scala 2.13 just not as good
at detecting missing cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
