olabusayoT commented on code in PR #1434:
URL: https://github.com/apache/daffodil/pull/1434#discussion_r1956797372
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/grammar/primitives/PrimitivesTextNumber.scala:
##########
@@ -464,6 +464,7 @@ case class ConvertTextStandardNumberPrim(e: ElementBase)
),
pattern
)
+ case _ => Assert.impossibleCase("default case should not be reached")
Review Comment:
it might not be, it was complaining about Some(_) when we had
Some(something...), so I'll look into these abit more and report the errors. Is
it better to address the specific cases it referenced as missing, rather than
using the default case...or should I add a comment with the cases it mentioned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
