mbeckerle commented on code in PR #1434:
URL: https://github.com/apache/daffodil/pull/1434#discussion_r1956545039
##########
daffodil-core/src/main/scala/org/apache/daffodil/core/dsom/RestrictionUnion.scala:
##########
@@ -168,7 +168,7 @@ final class Restriction private (xmlArg: Node, val
simpleTypeDef: SimpleTypeDefB
if (hasPattern) {
val lPattern = localBaseFacets.filter { case (f, v) => f ==
Facet.pattern }
val rPattern = remoteBaseFacets.filter { case (f, v) => f ==
Facet.pattern }
- val cPattern = lPattern.union(rPattern)
+ val cPattern = lPattern ++: rPattern
Review Comment:
I prefer named methods for set operations generally. So they removed 'union'
? Grrrrrr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
