stevedlawrence commented on code in PR #1516:
URL: https://github.com/apache/daffodil/pull/1516#discussion_r2240505286
##########
daffodil-core/src/main/scala/org/apache/daffodil/lib/oolag/OOLAG.scala:
##########
@@ -450,7 +450,7 @@ object OOLAG {
final def warnings: Seq[api.Diagnostic] = oolagRoot.warnings_.toSeq
override def getDiagnostics: java.util.List[api.Diagnostic] =
- diagnostics
+ diagnostics.asJava
Review Comment:
OOLAG is an internal thing, so I would think we want to keep its diagnostics
as a Seq. Ideally, java.util.List would be used on the public API boundary and
not internally.
I wonder if we need two kinds of WithDiagnostics? The internal
iapi.WithDiagnostics would return a Seq, and the public api.WithDiagnostics
would return a List? And we would have to be careful to ensure internal things
implement iapi.WithDiagnostics and public things implement api.WithDiagnostics.
I wonder if that would cause issues or run into any conflicts where something
needs to implement both iapi and api WithDiagnostics and would cause issues.
Probably isn't a big deal if it causes cascading issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
