stevedlawrence commented on code in PR #1516:
URL: https://github.com/apache/daffodil/pull/1516#discussion_r2240802646
##########
daffodil-core/src/main/scala/org/apache/daffodil/lib/oolag/OOLAG.scala:
##########
@@ -450,7 +450,7 @@ object OOLAG {
final def warnings: Seq[api.Diagnostic] = oolagRoot.warnings_.toSeq
override def getDiagnostics: java.util.List[api.Diagnostic] =
- diagnostics
+ diagnostics.asJava
Review Comment:
Yeah, that could certainly cause confusion. I guess also OOLAG is only used
during compile time where speed is important but not as critical. So this is
probably fine, not worth worrying about unless it shows up in profiling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
