olabusayoT commented on code in PR #1516:
URL: https://github.com/apache/daffodil/pull/1516#discussion_r2240715218
##########
daffodil-core/src/main/scala/org/apache/daffodil/lib/oolag/OOLAG.scala:
##########
@@ -450,7 +450,7 @@ object OOLAG {
final def warnings: Seq[api.Diagnostic] = oolagRoot.warnings_.toSeq
override def getDiagnostics: java.util.List[api.Diagnostic] =
- diagnostics
+ diagnostics.asJava
Review Comment:
Hmm, we do have cases where an object implements both, but I think my main
opposition will be lack of consistency where sometimes getDiagnostics returns
Seq if it's using the internal PF, or if it's using the api PF, it returns a
List...are we ok with this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
