stricklandrbls commented on PR #1384:
URL: https://github.com/apache/daffodil-vscode/pull/1384#issuecomment-3238410789
> > > Please change .includes to .endsWith. The filename is user-defined and
potentially could include .tdml as a part of the filename.
> >
> >
> > Resolved.
>
> Just checked the apache page for TDML and it lists .tdml.xml as a valid
extension as well (even though we're not using that here)
>
> Would the following work?
>
> return (file.endsWith('.tdml') || file.endsWith('.tdml.xml')) ? file :
file + '.tdml'
I think the best solution would be to determine to beginning of the
extension text `file.indexOf('.')` or `file.split('.')` and the using
`extStr.includes('tdml')`
I'll try to work something in along those lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
