stricklandrbls commented on PR #1384: URL: https://github.com/apache/daffodil-vscode/pull/1384#issuecomment-3272364279
> I think we need the following changes: > > * We're missing a `$` after the .tdml.xml case > > * We shouldn't be using `/m` as pathStr shouldn't ever contain newlines > > * We should be using `/i` because .TDML is a valid extension in at least Windows > > * I don't think we need the `.*` before the extension (since we're not using `^`). Some regex libraries force match on a whole string, but I don't believe this is one of them. > @michael-hoke - Resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
