michael-hoke commented on PR #1384: URL: https://github.com/apache/daffodil-vscode/pull/1384#issuecomment-3238443943
A valid filename here could be test.tdml.gif.final.tdml - I really think we need to use endsWith instead of indexOf/split/includes. We're using a saveFileDialog in this specific case, and I'm not sure what kind of convenience method we could use for a save - typically, those return the last chunk of text after the last dot (eg. they'll return .gz for a .tar.gz file), and we wouldn't want to force append .tdml to a .tdml.xml extension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
