JeremyYao commented on code in PR #1403:
URL: https://github.com/apache/daffodil-vscode/pull/1403#discussion_r2334418477
##########
src/daffodilDebugger/debugger.ts:
##########
@@ -58,12 +58,18 @@ async function getTDMLConfig(
config.schema.path = ''
config.tdmlConfig.path =
- config.tdmlConfig.path ||
- (await vscode.commands.executeCommand(
- 'extension.dfdl-debug.getValidatedTDMLPath'
- ))
+ config.tdmlConfig.path == '${AskForValidatedTDMLPath}'
+ ? await vscode.commands.executeCommand(
+ 'extension.dfdl-debug.getValidatedTDMLPath'
+ )
+ : config.tdmlConfig.path
- if (!config.tdmlConfig.path) return false
+ if (!config.tdmlConfig.path) {
+ vscode.window.showErrorMessage(
+ `Invalid path TDML Execute path ${config.tdmlConfig.path} was
specified!`
+ )
+ return false
+ }
Review Comment:
> If the user sends in an undefined or empty tdmlConfig.path, they will no
longer be prompted for a path. I don't think that behavior should be regressed.
If we see an undefined/empty path, I think we should prompt the user for the
path instead of letting them know they made a mistake with their launch config
and forcing them to fix it and restart.
Re-added via
https://github.com/apache/daffodil-vscode/pull/1403/commits/bcb1c9bf52cd1e6ced778f38e65310366b7a5978.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
