JeremyYao commented on code in PR #1403:
URL: https://github.com/apache/daffodil-vscode/pull/1403#discussion_r2341872682


##########
src/daffodilDebugger/debugger.ts:
##########
@@ -78,7 +78,7 @@ async function getTDMLConfig(
   if (config?.tdmlConfig?.action === 'generate') {
     config.tdmlConfig.name =
       config.tdmlConfig.name || getDefaultTDMLTestCaseName()
-    config.tdmlConfig.path = config.tdmlConfig.path || getTmpTDMLFilePath()
+    config.tdmlConfig.path = getTmpTDMLFilePath()

Review Comment:
   > Didn't realize the commit tab went top to bottom - looked like it got 
added back in to me...
   > 
   > Do we need to do this here? Is this code necessary for #1347 to be 
resolved? I don't think it does, and it helps to separate this from #1376
   
   Let's get others' input on this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to