JeremyYao commented on code in PR #1403:
URL: https://github.com/apache/daffodil-vscode/pull/1403#discussion_r2334365439
##########
src/daffodilDebugger/debugger.ts:
##########
@@ -58,12 +58,18 @@ async function getTDMLConfig(
config.schema.path = ''
config.tdmlConfig.path =
- config.tdmlConfig.path ||
- (await vscode.commands.executeCommand(
- 'extension.dfdl-debug.getValidatedTDMLPath'
- ))
+ config.tdmlConfig.path == '${AskForValidatedTDMLPath}'
+ ? await vscode.commands.executeCommand(
+ 'extension.dfdl-debug.getValidatedTDMLPath'
+ )
+ : config.tdmlConfig.path
- if (!config.tdmlConfig.path) return false
+ if (!config.tdmlConfig.path) {
+ vscode.window.showErrorMessage(
+ `Invalid path TDML Execute path ${config.tdmlConfig.path} was
specified!`
+ )
+ return false
+ }
Review Comment:
For the duplicate error message, I changed the if block to
```Typescript
if (!config.tdmlConfig.path) {
return false
}
```
to remove the duplicate error message in
https://github.com/apache/daffodil-vscode/pull/1403/commits/56fcfad6ef6a0bacf90495b2573ca79a5a0b3f08
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
