leerho commented on PR #558: URL: https://github.com/apache/datasketches-cpp/pull/558#issuecomment-6535662515
Thanks, Rusty. The DuckDB numbers make a strong case, and the reworked storage helpers from proost's review are a clean way to handle an unallocated `items_`. Because the same choice affects several sketches (KLL, t-digest and REQ here, and the same sketches in Java), we'd like to agree on one convention across the project before merging any of them. I've posted a proposal on dev@ as a lazy consensus ending Nov 7, 01:00 UTC: https://lists.apache.org/thread/rv730qo61qqkd99dcy4wnglf3hz1s0fz In short, it proposes allocating item storage on first use by default, with an explicit `reserve()` for users who want it up front, and keeping the basic exception guarantee on the first `update()`/`merge()` when allocation fails. I'm marking this PR as a draft until that resolves. If it passes, we'd like to build on this PR, possibly with a `reserve()` added. Comments on the proposal are very welcome, on the list or here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
