stojkomilos commented on PR #558: URL: https://github.com/apache/datasketches-cpp/pull/558#issuecomment-6714172843
@rustyconover Nice work. Please add geometric increasing of size for the first level/layer of the sketch, just like your other PR https://github.com/apache/datasketches-cpp/pull/561, and just like theta and tuple do this also already on master. If you don't want to do that in this PR, that is reasonable. I will do it after you merge this one (I already have a drafted PR for this). Perhaps @leerho can give his 2 cents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
