rustyconover commented on PR #558:
URL: https://github.com/apache/datasketches-cpp/pull/558#issuecomment-6725681974

   @leerho following up now that the proposal's November 7, 01:00 UTC deadline 
has passed. I see a supportive reply and no objections in the [archived 
thread](https://lists.apache.org/thread/rv730qo61qqkd99dcy4wnglf3hz1s0fz). 
Could you confirm whether the proposal is accepted and when we can take #558 
and #561 out of draft? You offered to make the C++ and Java changes starting 
from these PRs; are you planning to add `reserve()`, the allocation-failure 
tests and the associated documentation, or would you prefer that I update these 
branches?
   
   @stojkomilos thanks for offering to handle geometric growth and putting 
together #569. I'd like to keep this PR focused on allocation on first use and 
leave geometric growth to your follow-up in #569 after this merges. Please go 
ahead with polishing that PR on that basis, subject to the project's allocation 
convention.
   
   @proost could you take another look at `1fcf432f`? It centralizes 
allocation, copying and access to item ranges in `allocate_items()`, 
`copy_items()` and `item_ptr()`, including the empty `sort_level_zero()` path 
you flagged. All 21 checks now pass, including ASan, UBSan and libc++ 
hardening. I've also updated the PR description to match the current 
implementation. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to