guilhem commented on code in PR #272:
URL:
https://github.com/apache/incubator-devlake-helm-chart/pull/272#discussion_r1578066540
##########
charts/devlake/templates/ingresses.yaml:
##########
@@ -63,8 +63,12 @@ spec:
- path: /{{ include "devlake.grafanaEndpointPrefix" . }}
{{- end }}
{{- if semverCompare ">=1.18-0"
$.Capabilities.KubeVersion.GitVersion }}
+ {{- if .Values.ingress.useDefaultNginx }}
+ pathType: ImplementationSpecific
Review Comment:
in fact, I just copy paste exactly what was working before:
```
{{- if semverCompare ">=1.19-0"
$.Capabilities.KubeVersion.GitVersion }}
service:
name: {{ .Values.grafana.ingressServiceName | default (
include "grafana.fullname" (dict "Values" .Values.grafana "Chart" (dict "Name"
"grafana") "Release" .Release ) ) }}
port:
number: {{ .Values.grafana.ingressServicePort | default
.Values.grafana.service.port }}
{{- else }}
serviceName: {{ .Values.grafana.ingressServiceName | default (
include "grafana.fullname" (dict "Values" .Values.grafana "Chart" (dict "Name"
"grafana") "Release" .Release ) ) }}
servicePort: {{ .Values.grafana.ingressServicePort | default
.Values.grafana.service.port }}
{{- end }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
