ZhangNing10 commented on PR #272: URL: https://github.com/apache/incubator-devlake-helm-chart/pull/272#issuecomment-2076787639
> > hi @guilhem @JorgeGar , i have to revert this pr as having two ingresses can result in waste when the ingress class is alb, it would create two aws alb, i have created a pr #278 for this issue, could you check whether this pr solves your issue? > > Hi @ZhangNing10 this is not the case since 2020 and controller v2: https://aws.amazon.com/fr/blogs/containers/introducing-aws-load-balancer-controller/ > > you can use: > > ```yaml > metadata: > annotation: > alb.ingress.kubernetes.io/group.name: devlake > ``` > > which is supported by this PR as we are sharing the same `.Values.ingress.annotations` for both ingresses :) Hi @guilhem , thanks for the info! As the grafana specifies `root_url: "%(protocol)s://%(domain)s/grafana"` with a subpath grafana, so i think for internal grafana, no need to rewrite target, while for an external grafana, rewrite target should be needed. So, i removed the rewrite target path for the first ingress, could you help review the pr https://github.com/apache/incubator-devlake-helm-chart/pull/278 and check whether it includes the fix of the issue you found? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
