JorgeGar commented on code in PR #272:
URL:
https://github.com/apache/incubator-devlake-helm-chart/pull/272#discussion_r1578897708
##########
charts/devlake/templates/ingresses.yaml:
##########
@@ -131,19 +108,27 @@ spec:
- host: {{ .Values.ingress.hostname | quote }}
http:
paths:
+ {{- if .Values.ingress.useDefaultNginx }}
- path: /{{ include "devlake.grafanaEndpointPrefix" . }}(/|$)(.*)
+ {{- else }}
+ - path: /{{ include "devlake.grafanaEndpointPrefix" . }}
+ {{- end }}
{{- if semverCompare ">=1.18-0"
$.Capabilities.KubeVersion.GitVersion }}
+ {{- if .Values.ingress.useDefaultNginx }}
+ pathType: ImplementationSpecific
+ {{- else }}
pathType: Prefix
{{- end }}
- backend: # dummy to config-ui, actual 302 forearding for external
grafana
+ {{- end }}
+ # dummy in case of external grafana (redirect 308)
+ backend:
{{- if semverCompare ">=1.19-0"
$.Capabilities.KubeVersion.GitVersion }}
service:
- name: {{ $uiServiceName }}
+ name: {{ .Values.grafana.ingressServiceName | default (
include "grafana.fullname" (dict "Values" .Values.grafana "Chart" (dict "Name"
"grafana") "Release" .Release ) ) }}
port:
- number: 4000
+ number: {{ .Values.grafana.ingressServicePort | default
.Values.grafana.service.port }}
Review Comment:
@guilhem if you could kindly take a look into this, the rest is looking
great and I'm happy to approve it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
