ruanwenjun commented on code in PR #18174:
URL:
https://github.com/apache/dolphinscheduler/pull/18174#discussion_r3097403603
##########
dolphinscheduler-extract/dolphinscheduler-extract-base/src/main/java/org/apache/dolphinscheduler/extract/base/future/ResponseFuture.java:
##########
@@ -23,13 +23,13 @@
import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
-import lombok.Getter;
-import lombok.Setter;
+import lombok.Data;
import lombok.ToString;
import lombok.extern.slf4j.Slf4j;
@ToString
@Slf4j
+@Data
Review Comment:
Not all field should exposed to out layer, e.g `latch`, don't change the
code you are not clear.
##########
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/base/ParamsProps.java:
##########
@@ -17,49 +17,31 @@
package org.apache.dolphinscheduler.spi.params.base;
+import lombok.Data;
+import lombok.experimental.Accessors;
+
import com.fasterxml.jackson.annotation.JsonProperty;
/**
* the props field in form-create`s json rule
*/
+@Data
+@Accessors(chain = true)
public class ParamsProps {
+ @JsonProperty("placeholder")
Review Comment:
Why add this?
##########
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/base/ParamsProps.java:
##########
@@ -17,49 +17,31 @@
package org.apache.dolphinscheduler.spi.params.base;
+import lombok.Data;
+import lombok.experimental.Accessors;
+
import com.fasterxml.jackson.annotation.JsonProperty;
/**
* the props field in form-create`s json rule
*/
+@Data
+@Accessors(chain = true)
Review Comment:
```suggestion
@Accessors(chain = true)
```
Why add this?
##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/model/TaskNode.java:
##########
@@ -142,98 +143,11 @@ public class TaskNode {
private TaskExecuteType taskExecuteType;
- public String getId() {
- return id;
- }
-
- public void setId(String id) {
- this.id = id;
- }
-
- public String getName() {
- return name;
- }
-
- public void setName(String name) {
- this.name = name;
- }
-
- public String getDesc() {
- return desc;
- }
-
- public void setDesc(String desc) {
- this.desc = desc;
- }
-
- public String getType() {
- return type;
- }
-
- public void setType(String type) {
- this.type = type;
- }
-
- public String getParams() {
- return params;
- }
-
- public void setParams(String params) {
- this.params = params;
- }
-
- public String getPreTasks() {
- return preTasks;
- }
-
public void setPreTasks(String preTasks) {
this.preTasks = preTasks;
this.depList = JSONUtils.toList(preTasks, Long.class);
}
- public String getExtras() {
- return extras;
- }
-
- public void setExtras(String extras) {
- this.extras = extras;
- }
-
- public List<Long> getDepList() {
- return depList;
- }
-
- public void setDepList(List<Long> depList) {
- if (depList != null) {
- this.depList = depList;
- this.preTasks = JSONUtils.toJsonString(depList);
- }
- }
Review Comment:
Can we remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
