njnu-seafish commented on code in PR #18174:
URL:
https://github.com/apache/dolphinscheduler/pull/18174#discussion_r3099212015
##########
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/base/ParamsProps.java:
##########
@@ -17,49 +17,31 @@
package org.apache.dolphinscheduler.spi.params.base;
+import lombok.Data;
+import lombok.experimental.Accessors;
+
import com.fasterxml.jackson.annotation.JsonProperty;
/**
* the props field in form-create`s json rule
*/
+@Data
+@Accessors(chain = true)
public class ParamsProps {
+ @JsonProperty("placeholder")
Review Comment:
> Why add this?
Here is the code before refactoring：
public ParamsProps setPlaceholder(String placeholder) {
this.placeholder = placeholder;
return this;
}
Yes, this is not used.
<img width="1813" height="1021" alt="企业微信截图_17764183474087"
src="https://github.com/user-attachments/assets/0bb71034-4058-4c27-ac98-4ca44d12869a";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
