github-advanced-security[bot] commented on code in PR #18174: URL: https://github.com/apache/dolphinscheduler/pull/18174#discussion_r3166545288
########## dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-oceanbase/src/main/java/org/apache/dolphinscheduler/plugin/datasource/oceanbase/param/OceanBaseDataSourceParamDTO.java: ########## @@ -20,20 +20,18 @@ import org.apache.dolphinscheduler.plugin.datasource.api.datasource.BaseDataSourceParamDTO; import org.apache.dolphinscheduler.spi.enums.DbType; +import lombok.Data; +import lombok.EqualsAndHashCode; + +@EqualsAndHashCode(callSuper = true) Review Comment: ## CodeQL / Missing Override annotation This method overrides [BaseDataSourceParamDTO.canEqual](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5747) ########## dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/number/InputNumberParamProps.java: ########## @@ -20,10 +20,12 @@ import org.apache.dolphinscheduler.spi.params.base.ParamsProps; import lombok.Data; +import lombok.EqualsAndHashCode; /** * front-end input number component props attributes */ +@EqualsAndHashCode(callSuper = true) Review Comment: ## CodeQL / Missing Override annotation This method overrides [ParamsProps.canEqual](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5752) ########## dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/input/InputParamProps.java: ########## @@ -21,10 +21,12 @@ import org.apache.dolphinscheduler.spi.params.base.ResizeType; import lombok.Data; +import lombok.EqualsAndHashCode; /** * front-end input component props attributes */ +@EqualsAndHashCode(callSuper = true) Review Comment: ## CodeQL / Missing Override annotation This method overrides [ParamsProps.canEqual](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5753) ########## dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/params/radio/RadioParamProps.java: ########## @@ -20,10 +20,12 @@ import org.apache.dolphinscheduler.spi.params.base.ParamsProps; import lombok.Data; +import lombok.EqualsAndHashCode; /** * front-end radio component props attributes */ +@EqualsAndHashCode(callSuper = true) Review Comment: ## CodeQL / Missing Override annotation This method overrides [ParamsProps.canEqual](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5754) ########## dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetSqlServerParameter.java: ########## @@ -19,6 +19,11 @@ import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter; +import lombok.Data; +import lombok.EqualsAndHashCode; + +@EqualsAndHashCode(callSuper = true) Review Comment: ## CodeQL / Missing Override annotation This method overrides [TargetCommonParameter.canEqual](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5751) ########## dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetOracleParameter.java: ########## @@ -19,6 +19,11 @@ import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter; +import lombok.Data; +import lombok.EqualsAndHashCode; + +@EqualsAndHashCode(callSuper = true) Review Comment: ## CodeQL / Missing Override annotation This method overrides [TargetCommonParameter.canEqual](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5750) ########## dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetMysqlParameter.java: ########## @@ -19,6 +19,11 @@ import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter; +import lombok.Data; +import lombok.EqualsAndHashCode; + +@EqualsAndHashCode(callSuper = true) Review Comment: ## CodeQL / Missing Override annotation This method overrides [TargetCommonParameter.canEqual](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5749) ########## dolphinscheduler-task-plugin/dolphinscheduler-task-sqoop/src/main/java/org/apache/dolphinscheduler/plugin/task/sqoop/parameter/targets/TargetHanaParameter.java: ########## @@ -19,6 +19,11 @@ import org.apache.dolphinscheduler.plugin.task.sqoop.parameter.TargetCommonParameter; +import lombok.Data; +import lombok.EqualsAndHashCode; + +@EqualsAndHashCode(callSuper = true) Review Comment: ## CodeQL / Missing Override annotation This method overrides [TargetCommonParameter.canEqual](1); it is advisable to add an Override annotation. [Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5748) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
