njnu-seafish commented on code in PR #18549: URL: https://github.com/apache/dolphinscheduler/pull/18549#discussion_r3773943753
########## docs/docs/en/guide/upgrade/incompatible.md: ########## @@ -47,4 +47,5 @@ This document records the incompatible updates between each version. You need to ## 3.5.0 * Add the `missed_fire_policy` column to `t_ds_schedules`. Existing schedules default to `FIRE_ALL_MISSED` to preserve the previous Quartz `IgnoreMisfires` behavior. ([#18464](https://github.com/apache/dolphinscheduler/pull/18464)) +* Rename the `sendEmail` field in SQL task parameters to `sendAlert`. The data migration script will automatically migrate `sendEmail` to `sendAlert` in the `t_ds_task_definition` and `t_ds_task_definition_log` tables.([#18549](https://github.com/apache/dolphinscheduler/pull/18549)) Review Comment: > We should not change field name. There is nothing wrong with the old name. However, alerts for SQL task results aren't limited to email; they can be sent through other channels as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
