njnu-seafish commented on PR #18549: URL: https://github.com/apache/dolphinscheduler/pull/18549#issuecomment-5408484628
> #### Include the task identity in the idempotency key > `generateSign()` hashes only the alert content. The new idempotent insert treats an alert as duplicated when its `sign`, `workflow_instance_id`, and `alert_type` are equal. > > If two different SQL tasks in the same workflow instance return identical results, the second task's alert will be silently skipped, even when it has a different title or alert group. > > Please include a stable task execution identity, such as the task instance ID, in the idempotency key. This will deduplicate retries of the same success event without suppressing alerts generated by different tasks. Thanks for the thorough review! Both issues have been addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
