njnu-seafish commented on PR #18549: URL: https://github.com/apache/dolphinscheduler/pull/18549#issuecomment-5450251881
> #### 3. The null-alert-type fallback cannot protect an old Alert Server > The new fallback in `AlertSender#getAlertData()` cannot fix the documented rolling-upgrade scenario. An old Alert Server is running the old implementation, so it does not contain this null guard. > > On a new Alert Server, `TASK_RESULT` is already known and will not be mapped to null. Therefore, this fallback only handles corrupted data or values introduced by an even newer version, and converting either case to `WORKFLOW_INSTANCE_FAILURE` silently sends an alert with the wrong semantic type. > > Please rely on and enforce the documented component upgrade order, or preserve the unknown numeric value through deserialization. Do not silently relabel an unknown alert as a workflow failure. thanks. doned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
