det101 commented on PR #18585: URL: https://github.com/apache/dolphinscheduler/pull/18585#issuecomment-5538120479
@SbloodyS Thank you — the create/update plaintext leak is addressed at the HTTP outbound boundary (`SensitivePropertyResponseAdvice` copy-then-masks `Result.data` after persistence). Service / persisted objects stay plaintext for execution. We also added the three regressions you asked for: 1. Creating a workflow with a sensitive global parameter 2. Updating a workflow with a new sensitive value 3. Updating a workflow instance that already has a sensitive global parameter Each asserts the HTTP `Result` contains `******` while the object passed to `saveWorkflowDefine` remains the real value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
